<html>
<head><meta charset="utf-8"><title>generator pr chalk#593 · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html">generator pr chalk#593</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="211687039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687039">(Sep 29 2020 at 21:29)</a>:</h4>
<p>So <span class="user-mention" data-user-id="125294">@Aaron Hill</span> and <span class="user-mention" data-user-id="232957">@Jack Huey</span> I just reviewed <a href="https://github.com/rust-lang-nursery/chalk/issues/593">chalk#593</a> which is great.</p>



<a name="211687103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687103">(Sep 29 2020 at 21:30)</a>:</h4>
<p>I left a nit or two about docs/syntax but I would be happy to land as is too</p>



<a name="211687329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687329">(Sep 29 2020 at 21:32)</a>:</h4>
<p>If <span class="user-mention" data-user-id="125294">@Aaron Hill</span> has time "soon" to address review, I say wait. Otherwise, I would prefer landing and iterating after.</p>



<a name="211687348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687348">(Sep 29 2020 at 21:32)</a>:</h4>
<p>I can address those comments later today</p>



<a name="211687394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687394">(Sep 29 2020 at 21:32)</a>:</h4>
<p>Feel free to merge when they're done then :)</p>



<a name="211687512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211687512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211687512">(Sep 29 2020 at 21:33)</a>:</h4>
<p>Works for me</p>



<a name="211697550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/generator%20pr%20chalk%23593/near/211697550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/generator.20pr.20chalk.23593.html#211697550">(Sep 29 2020 at 23:26)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> Done</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>